Repository navigation
fix(基础库): 统一平台判定并修正路径展开与管道关闭 - #417
Merged
Merged
Conversation
|
Hi @Mikachu2333 ❤️ 感谢你的贡献！我们将在最少半小时，最多5天内阅读此 PR 并回复你 |
ccmywish
requested changes
Nov 10, 2026
Mikachu2333
force-pushed
the
split/env-xy-portability
branch
from
November 10, 2026 13:59
87b9247 to
fa1a78d
Compare
Mikachu2333
commented
Nov 10, 2026
| wchar_t *wpath = _xy_win_wstr (new); | ||
| if (wpath) | ||
| { | ||
| DWORD needed = ExpandEnvironmentStringsW (wpath, NULL, 0); |
Collaborator
Author
There was a problem hiding this comment.
注，这个地方等env合入以后可以直接调用现成的函数，不再需要手写解析
ccmywish
reviewed
Nov 11, 2026
ccmywish
requested changes
Nov 11, 2026
Mikachu2333
force-pushed
the
split/env-xy-portability
branch
from
November 11, 2026 06:24
fa1a78d to
c974c98
Compare
ccmywish
approved these changes
Nov 13, 2026
Contributor
|
文件有冲突了，需要改一下 |
编译期与运行期 Windows 判定可能不一致，路径检查缺少空指针保护，管道关闭也未统一平台接口。 统一平台判定与 xy_pclose，支持 Windows 路径环境变量展开，并补充路径相关测试。 从 RubyMetric#402 按功能拆出，直接基于 dev；Windows/POSIX 独立构建及现有测试通过。
perf(基础库): 减少路径判断的重复查询和编码转换
Mikachu2333
force-pushed
the
split/env-xy-portability
branch
from
November 13, 2026 04:45
1844ee6 to
6a8c415
Compare
Collaborator
Author
|
改完了，已rebase完毕 |
ccmywish
approved these changes
Nov 13, 2026
Contributor
|
通过这个例子，我觉得 AI 能写出看似正确的代码，但是有时候并不正确。 |
Collaborator
Author
确实，这也非常考验审核者的经验积累，由于我本人不用msys2和cygwin，因此在审查的时候查了一下资料感觉正确就跳过了 |
Collaborator
Author
|
那等我再提个pr改一下这个地方？还是你改？ @ccmywish |
Collaborator
Author
|
看到了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题描述
编译期与运行期 Windows 判定可能不一致，路径检查缺少空指针保护，管道关闭也未统一平台接口。
关联 #402。
方案与实现
统一平台判定与 xy_pclose，支持 Windows 路径环境变量展开，并补充路径相关测试。
本 PR 从 #402 独立拆出，直接基于
dev，可以单独审查和合并。验证：此分支独立通过 Windows
just build/test/bd、WSL Debianmake build/test/bd，以及调试程序的只读查询。