util/attributes: Error on #[repr] applied to functions #4355
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasta-coder
force-pushed
the
fix/repr-invalid-4232
branch
from
c1894f9 to
534d601
Compare
Contributor
Author
|
drafted to resolve conflicts |
Pasta-coder
force-pushed
the
fix/repr-invalid-4232
branch
from
2128917 to
98a508e
Compare
The #[repr] attribute is only valid for structs, enums, and unions. Applying it to a function is invalid and should result in an error. This patch adds a check in the attribute visitor to reject #[repr] on functions, matching rustc behavior. Fixes Rust-GCC#4232 gcc/rust/ChangeLog: * util/rust-attributes.cc (AttributeChecker::check_attributes): Emit error for #[repr]. gcc/testsuite/ChangeLog: * rust/compile/issue-4232.rs: New test. Signed-off-by: Jayant Chauhan <[email protected]>
Pasta-coder
force-pushed
the
fix/repr-invalid-4232
branch
from
98a508e to
3c307f9
Compare
Contributor
Author
|
@P-E-P please review . thankyou . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #[repr] attribute is only valid for structs, enums, and unions. Applying it to a function is invalid and should result in an error. This patch adds a check in the attribute visitor to reject #[repr] on functions, matching rustc behavior.
Fixes #4232
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: