Put commands in their own files and some stricter lints#25
Put commands in their own files and some stricter lints#25schell merged 4 commits intoRust-GPU:mainfrom
Conversation
No other changes, just moving code.
schell
left a comment
schell
left a comment
There was a problem hiding this comment.
Great changes! I only had one nitpicky change request about the name of the "builder" module, but my opinion on it is not that strong 👍
| @@ -1,8 +1,8 @@ | |||
| name: push | |||
|
|
|||
| on: | |||
There was a problem hiding this comment.
I'm surprised my editor is leaving this whitespace!
| /// Rust toolchain channel to use to build `spirv-builder`. | ||
| /// | ||
| /// This must match the `spirv_builder` argument. | ||
| /// This must be compatible with the `spirv_builder` argument as defined in the `rust-gpu` repo. |
| for entry in std::fs::read_dir(&release).unwrap() { | ||
| let entry = entry.unwrap(); | ||
| for maybe_entry in std::fs::read_dir(&release).unwrap() { | ||
| let entry = maybe_entry.unwrap(); |
| for sub in cmd.get_subcommands_mut() { | ||
| let _ = writeln!(buffer); | ||
| writeln!(buffer).unwrap(); | ||
| #[expect(clippy::used_underscore_binding, reason = "Used in recursion only")] |
There was a problem hiding this comment.
I've never seen this macro/annotation before (expect) - cool :)
There was a problem hiding this comment.
It's really new actually, like just became stable a few months ago.
|
There's 2 new commits now. The first new one adds an actual And the second new commit is just cos I want to rebase it into the first commit before merging the PR. I like to try for linear history. |
I was juggling a couple projects at once and using one of those to debug this one, and simply wasn't as thorough as I should have been, but luckily we've got @tombh to pick up the slack, thanks! Awesome! Thanks for this. |
2 participants
There are 2 commits. The first just splits up
main.rsso that each command has its own file. And the second commit adds some stricter lints and makes them happy, most of which involves adding documentation. So it's worth reviewing each commit separately to get a better idea of the changes. I'm not 100% I have the best understanding of some things, so some of the comments I've added or amended might not be correct.The new lints are quite a bit stricter, which might not be the most appropriate for this repo. Maybe they're overkill? The only one I think is important is the
missing_docs = "warn"one.