Fix clippy warnings #137
Merged
Fix clippy warnings #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Well this is quite important. I'm definitely kicking myself for not having clippy in CI prior to #128 or before releasing |
Contributor
Author
|
I can add a clippy job to ci. And why not rustfmt as well when we are at it. Should I just include that in this pr? |
Member
Sounds good to me! |
Contributor
Author
|
Done :) |
Contributor
Author
|
Sweet, thanks for handling this so quickly :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues clippy finds. The most important ones are the
set_propertyandget_propertyfunctions in the audio_unit module. They trigger thenot_unsafe_ptr_arg_dereflint because they accept a pointer to an AudioUnit instance, but they cannot check that the pointer is valid, and therefore the caller must be responsible for this. They should be marked as unsafe to reflect this. Instead using the associated methods on the AudioUnit structure is safe and should be the preferred way.The clippy docs strongly recommend against disabling the
not_unsafe_ptr_arg_derefrule, so I marked the functions as unsafe. This is a small breaking change, but this still seems like a better alternative than disabling the rule (and we could also discuss if these functions should bepubat all, but now they are, so removing them from the public api could cause trouble for some users).