Expose const_choice.rs functions #994
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tarcieri
reviewed
Oct 23, 2025
| /// **Note:** if the second element is `None`, the first value may take any value. | ||
| #[inline] | ||
| pub(crate) const fn components_ref(&self) -> (&T, ConstChoice) { | ||
| pub const fn components_ref(&self) -> (&T, ConstChoice) { |
Member
There was a problem hiding this comment.
This is the only one I'm a bit wary of exposing. Notably it exposes the inner T which may be in an invalid state.
tarcieri
reviewed
Oct 23, 2025
Comment on lines
+438
to
+450
| impl<const LIMBS: usize> ConstCtOption<(Uint<LIMBS>, ConstChoice)> { | ||
| /// Returns the contained value, consuming the `self` value. | ||
| /// | ||
| /// # Panics | ||
| /// | ||
| /// Panics if the value is none with a custom panic message provided by | ||
| /// `msg`. | ||
| #[inline] | ||
| pub const fn expect(self, msg: &str) -> (Uint<LIMBS>, ConstChoice) { | ||
| assert!(self.is_some.is_true_vartime(), "{}", msg); | ||
| self.value | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I assume this is related to components_ref somehow?
Member
|
Per the build failures, the functions that we do end up exposing will need documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #991