Skip to content

der: use strict context-specific skipping condition (equal tag numbers only) #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

der: use strict context-specific skipping condition (equal tag numbers only) #1740

wants to merge 2 commits into from

Conversation

dishmaker
Copy link
Contributor

@dishmaker dishmaker commented Mar 25, 2025 •
edited
Loading

@dishmaker dishmaker marked this pull request as draft March 25, 2025 11:03
@dishmaker
der: rename decode_with -> peek_tag_matches
5239f9e 
der: replace tag skip condition to `tag.number() != tag_number`

der: add class param to peek_decode_optional

der: peek_tag_matches bool
@dishmaker dishmaker force-pushed the dishmaker/peek_decode_optional branch from 21d4c6a to 5239f9e Compare April 21, 2025 16:56
@dishmaker dishmaker changed the title der: strict skipping condition in decode_with/peek_decode_optional der: strict skipping condition in decode_with/peek_tag_matches Apr 21, 2025
@dishmaker
Copy link
Contributor Author

dishmaker commented Apr 21, 2025 •
edited
Loading

Edit: solved

Looks like I broke something in pkcs8

     Running tests/builder.rs (target/debug/deps/builder-c42694f58bf84285)

running 9 tests
test dynamic_signer ... ok
test certificate_request_attributes ... ok
test certificate_request ... ok
test async_builder ... ok
test leaf_certificate has been running for over 60 seconds
test pss_certificate has been running for over 60 seconds
test root_ca_certificate has been running for over 60 seconds
test root_ca_certificate_ecdsa has been running for over 60 seconds
test sub_ca_certificate has been running for over 60 seconds

@dishmaker
Copy link
Contributor Author

dishmaker commented Apr 21, 2025 •
edited
Loading

Edit: Master branch gets stuck too on cargo test --all --all-features

[Spoiler] htop

image

@dishmaker dishmaker marked this pull request as ready for review April 21, 2025 17:45
@tarcieri
Copy link
Member

What was causing the infinite loop? That seems bad

@dishmaker
Copy link
Contributor Author

zlint - htop screenshot above

@dishmaker dishmaker changed the title der: strict skipping condition in decode_with/peek_tag_matches der: use strict context-specific skipping condition (equal tag numbers only) Apr 22, 2025
@dishmaker dishmaker mentioned this pull request Apr 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

der: Correct context-specific skipping algorithm
2 participants
@dishmaker @tarcieri