Skip to content

docs: [HOTEL-20922] add reshopInfo field to rate details criteria #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 13, 2025

Conversation

gabriel-schiferdecke
Copy link
Contributor

@gabriel-schiferdecke gabriel-schiferdecke commented Apr 14, 2025

Overview

Add reshopInfo to modify/reshop flow for rate-details endpoint.

Evidences:

Screenshot 2025-06-12 at 13 39 00

Copy link

cla-assistant bot commented Apr 14, 2025

CLA assistant check
All committers have signed the CLA.

@gabriel-schiferdecke gabriel-schiferdecke changed the title docs: add reshopping information to rate details criteria docs: add reshopInfo field to rate details criteria Apr 14, 2025
Copy link
Contributor

@kunalshah01 kunalshah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update several other places:

  1. Schema documentation for RateDetailsCritera: https://developer.concur.com/api-reference/direct-connects/hotel-service-4/v4.schemas.html#-ratedetailscriteria
  2. Add another example of rate-details endpoint (https://developer.concur.com/api-reference/direct-connects/hotel-service-4/v4.endpoints.html#rate-details-) for modify feature.

Copy link
Contributor

@kunalshah01 kunalshah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see you defining #schemareshopinfo - which should link to Reshop schema details in v4.schemas.markdown

@gabriel-schiferdecke gabriel-schiferdecke changed the title docs: add reshopInfo field to rate details criteria docs: [HOTEL-20922] add reshopInfo field to rate details criteria May 20, 2025
Copy link
Contributor

@kunalshah01 kunalshah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure swagger file is valid and no syntax issues

@gabriel-schiferdecke gabriel-schiferdecke marked this pull request as ready for review June 12, 2025 16:50
CelesteCasali
CelesteCasali previously approved these changes Jun 12, 2025
Copy link
Member

@CelesteCasali CelesteCasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@CelesteCasali CelesteCasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants