Skip to content

Fiori Tree Views #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Apr 2, 2025
Merged

Fiori Tree Views #816

merged 40 commits into from
Apr 2, 2025

Conversation

etimr
Copy link
Contributor

@etimr etimr commented Mar 20, 2025

  • Read only Tree Table Genres as a separate tile in fiori application
  • Genres as Value Help in Books

Copy link

cla-assistant bot commented Mar 20, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ OlenaTi
✅ danjoa
✅ etimr
❌ johannes-vogel
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

cla-assistant bot commented Mar 20, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@etimr etimr marked this pull request as ready for review March 26, 2025 15:11
@etimr etimr requested review from danjoa and johannes-vogel March 31, 2025 11:33
@johannes-vogel
Copy link
Contributor

lgtm now, the test failures are caused by the csv inserts. SQLite does not require an ID_texts columns, HANA does. @danjoa Do you have an idea for this?

Copy link
Member

@danjoa danjoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the below disclaimer messages.
With that we can merge and release.

Great work 👍
Thanks a lot!

@danjoa danjoa changed the title WIP: Tree Tables Fiori Tree Tables Apr 1, 2025
@danjoa danjoa changed the title Fiori Tree Tables Fiori Tree Views Apr 1, 2025
@danjoa danjoa merged commit 1ff53ed into main Apr 2, 2025
4 of 5 checks passed
@danjoa danjoa deleted the d070615-tree-table branch April 2, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants