Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate all control flow #13050

Merged
merged 5 commits into from
Feb 21, 2025
Merged

chore: migrate all control flow #13050

merged 5 commits into from
Feb 21, 2025

Conversation

robertIsaac
Copy link
Contributor

  • remove all usage of CommonModule
  • force the new control flow using eslint rule

@netlify Netlify
Copy link

netlify bot commented Feb 17, 2025 •
edited
Loading

✅ Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit d88206e
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/67b7a67b2418f700084d92d5
😎 Deploy Preview https://deploy-preview-13050--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@droshev droshev removed the request for review from shawchandankumar February 19, 2025 16:11
@droshev droshev added this to the Sprint 143 - February 2025 milestone Feb 19, 2025
@droshev droshev added the tooling tooling feature around fundamental-ngx label Feb 19, 2025
@droshev
Copy link
Contributor

droshev commented Feb 19, 2025

the core and platform unit tests are failing

@robertIsaac
Copy link
Contributor Author

I fixed them
had to revert one CommonModule import, no idea why it fails when I remove it, it's unused

@droshev droshev merged commit 3fda6e5 into main Feb 21, 2025
12 checks passed
@droshev droshev deleted the chore/control-flow branch February 21, 2025 03:15
@mikerodonnell89 mikerodonnell89 mentioned this pull request Feb 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droshev droshev droshev approved these changes

@mikerodonnell89 mikerodonnell89 Awaiting requested review from mikerodonnell89

Assignees

@robertIsaac robertIsaac

Labels
tooling tooling feature around fundamental-ngx
Projects
None yet
Milestone
Sprint 143 - February 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@robertIsaac @droshev @mikerodonnell89