feat: add new flag containerScan to detectExecuteScan #5312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Docker Inspector This change adds a new flag 'containerScan' that enables using the Detect CONTAINER_SCAN tool instead of Docker Inspector for container image scanning. When containerScan is set to true: - Only container image scanning is performed, other scans are skipped - Container scanning uses the Detect CONTAINER_SCAN tool - Docker Inspector parameters are not used The implementation includes: - New containerScan parameter in the step configuration - Updated logic in runDetect to handle the containerScan flag - Updated addDetectArgsImages to use container scan parameters - Unit tests to verify container scan functionality - Removed duplicated unit tests in TestAddDetectArgs
|
|
CCFenner
approved these changes
Apr 11, 2025
|
/it-go |
|
Hi @CCFenner regarding the integration test errors, they don't seem caused by my changes, should I take any actions on that or are they being handled separately? Example: |
|
/it-go |
|
/it-go |
|
|
/it-go |
maxatsap
added a commit
to maxatsap/jenkins-library
that referenced
this pull request
May 8, 2025
* origin: (27 commits) fix(golang): handle errors with simple module names (SAP#5339) Revert "fix(integration): Skip failing intergration tests for now (SAP#5… (SAP#5330) Abap env cf cli latest (SAP#5338) [golangBuild] Add better error logging to `isMainPackage` (SAP#5308) abapEnvironment steps cf-cli v12 to latest (SAP#5333) Add link to CNB docs for run images (SAP#5336) feat(detect): add flag containerScan to detect step (SAP#5312) fix(sonarExecuteScan): update sonarScannerDownloadUrl (SAP#5314) (improvement!) handle case if AdoPersonalAccessToken is not set (SAP#5322) fix(gcs): return Temporary hold error without retry (SAP#5335) feat(cnbBuild): enable additional syft catalogers for sbom generation (SAP#5332) chore(deps): Update direct dependencies (SAP#5327) fix(integration): Skip failing intergration tests for now (SAP#5329) Update CODEOWNERS for Sonar files (SAP#5317) chore(sonar): drop code ownership for sonar (SAP#5315) chore(): Replaced node version `lts-buster` with `lts-bookworm` (SAP#5286) feat: output hooks values in stage-config.json (SAP#5311) fix(docs): update Gauge url (SAP#5313) [ABAP] Add type to log output (SAP#5310) usage of BASH from PATH (SAP#5282) ...
maxatsap
added a commit
to maxatsap/jenkins-library
that referenced
this pull request
May 8, 2025
* origin: (27 commits) fix(golang): handle errors with simple module names (SAP#5339) Revert "fix(integration): Skip failing intergration tests for now (SAP#5… (SAP#5330) Abap env cf cli latest (SAP#5338) [golangBuild] Add better error logging to `isMainPackage` (SAP#5308) abapEnvironment steps cf-cli v12 to latest (SAP#5333) Add link to CNB docs for run images (SAP#5336) feat(detect): add flag containerScan to detect step (SAP#5312) fix(sonarExecuteScan): update sonarScannerDownloadUrl (SAP#5314) (improvement!) handle case if AdoPersonalAccessToken is not set (SAP#5322) fix(gcs): return Temporary hold error without retry (SAP#5335) feat(cnbBuild): enable additional syft catalogers for sbom generation (SAP#5332) chore(deps): Update direct dependencies (SAP#5327) fix(integration): Skip failing intergration tests for now (SAP#5329) Update CODEOWNERS for Sonar files (SAP#5317) chore(sonar): drop code ownership for sonar (SAP#5315) chore(): Replaced node version `lts-buster` with `lts-bookworm` (SAP#5286) feat: output hooks values in stage-config.json (SAP#5311) fix(docs): update Gauge url (SAP#5313) [ABAP] Add type to log output (SAP#5310) usage of BASH from PATH (SAP#5282) ...
maxatsap
added a commit
to maxatsap/jenkins-library
that referenced
this pull request
May 8, 2025
* origin: (27 commits) fix(golang): handle errors with simple module names (SAP#5339) Revert "fix(integration): Skip failing intergration tests for now (SAP#5… (SAP#5330) Abap env cf cli latest (SAP#5338) [golangBuild] Add better error logging to `isMainPackage` (SAP#5308) abapEnvironment steps cf-cli v12 to latest (SAP#5333) Add link to CNB docs for run images (SAP#5336) feat(detect): add flag containerScan to detect step (SAP#5312) fix(sonarExecuteScan): update sonarScannerDownloadUrl (SAP#5314) (improvement!) handle case if AdoPersonalAccessToken is not set (SAP#5322) fix(gcs): return Temporary hold error without retry (SAP#5335) feat(cnbBuild): enable additional syft catalogers for sbom generation (SAP#5332) chore(deps): Update direct dependencies (SAP#5327) fix(integration): Skip failing intergration tests for now (SAP#5329) Update CODEOWNERS for Sonar files (SAP#5317) chore(sonar): drop code ownership for sonar (SAP#5315) chore(): Replaced node version `lts-buster` with `lts-bookworm` (SAP#5286) feat: output hooks values in stage-config.json (SAP#5311) fix(docs): update Gauge url (SAP#5313) [ABAP] Add type to log output (SAP#5310) usage of BASH from PATH (SAP#5282) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a new flag 'containerScan' that enables using the Detect CONTAINER_SCAN tool instead of Docker Inspector for container image scanning.
When containerScan is set to true:
The implementation includes:
Checklist