Modify release action #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonarw
approved these changes
Nov 20, 2025
Contributor
yonarw
left a comment
yonarw
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up. The new setup makes much more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Release action as follows:
In the earlier version, we were having a job
pre-release-checkswhich installed the built artifact and tried running the tests using the built artifact.However, because we were running the tests in the same folder of the project, the classes were still being imported from the local module of the source code, making the process redundant.
Thus we remove the earlier job
pre-release-checksand we add a new jobrun_testsin the action and this references theci.ymlaction and first runs the unit and integration tests.Checking if there are any prerelease dependencies is also now in a separate job
check-prerelease-dependencies. This allows us for an early fail, instead of running the tests first and then check if there are any dependencies which haven't been released yet.