Add Optional mem-fs-editor to getProjectType and underlying functions
#2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 766291a The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…en-ux-tools into add-optional-memfs-editor
…en-ux-tools into add-optional-memfs-editor
devinea
previously approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Hi @kjose90, changes to support mem-fs-editor look good, please see my comments
Klaus-Keller
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Thanks @kjose90, all my comments are addressed
- code changes to enhance support of mem-fs-editor in project access look good
- changeset is correct
- test coverage is great
- did a visual review, no manual test
Approved from my side.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2762
Enhance the
getProjectTypefunction and its underlying logic by adding support for an optionalmem-fseditor. This will allow to access and manipulate the in-memory file structure.