Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbi(ui5-libs): support for deploying ui5 libs #2820

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

cianmSAP
Copy link
Contributor

#2819

  • Updates @sap-ux/ui5-library-writer, adding the scripts to for deploy config
  • Updates @sap-ux/abap-deploy-config-writer, adding the .Ui5RepositoryIgnore file for typescript libraries

Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: cd6c763

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/create Patch
@sap-ux/ui5-library-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cianmSAP cianmSAP requested review from docirl and devinea January 23, 2025 15:27
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.
Changset ✅
covered by tests.

Copy link
Contributor

@docirl docirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good
Tests added/updated and look as expected
Not tested locally

@cianmSAP cianmSAP merged commit ccb96dd into main Jan 27, 2025
16 checks passed
@cianmSAP cianmSAP deleted the tbi/ui5-libs/2819-deployment branch January 27, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants