Conversation
create application access from project
sync function
🦋 Changeset detectedLatest commit: 0ce6282 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
provide project through options instead of creating new function
missed file
815are
changed the title
createApplicationAccessFromProjectcreateApplicationAccess to allow create applicationAccess by passing existing instance of 'project' to avoid getProject call
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is existing method createApplicationAccess, which calls
findAllAppsandgetProject, wheregetProjectcould be performant action for large project.In this PR enhancing method
createApplicationAccess- it should allow to createapplicationAccessusing previously resolved object ofprojectdata and avoid multiple calls forgetProjectandfindAllApps