Skip to content

feat(generator-adp): Create a yeoman package for Adaptation Project generator#3031

Merged
nikmace merged 43 commits intomainfrom
feat/3015/adp-generator-package
Mar 26, 2025
Merged

feat(generator-adp): Create a yeoman package for Adaptation Project generator#3031
nikmace merged 43 commits intomainfrom
feat/3015/adp-generator-package

Conversation

@nikmace
Copy link
Copy Markdown
Contributor

@nikmace nikmace commented Mar 17, 2025

Feat for #3015.

  • Adds a new yeoman package which creates an Adaptation Project.
  • System and application prompts have been added from the start. The rest of the properties are filled from defaults

@nikmace nikmace self-assigned this Mar 17, 2025
@nikmace nikmace requested review from a team as code owners March 17, 2025 06:11
@nikmace nikmace linked an issue Mar 17, 2025 that may be closed by this pull request
FEATURE - Add Adaptation Project generator #3015
Open
4 tasks
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 17, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 1cd4977

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@sap-ux/generator-adp Minor
@sap-ux/axios-extension Patch
@sap-ux/inquirer-common Patch
@sap-ux/adp-tooling Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/app-config-writer Patch
@sap-ux/backend-proxy-middleware Patch
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/deploy-tooling Patch
@sap-ux/environment-check Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/system-access Patch
@sap-ux/ui-service-inquirer Patch
@sap-ux/ui-service-sub-generator Patch
@sap-ux/odata-cli Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/cf-deploy-config-sub-generator Patch
@sap-ux/create Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/ui5-library-reference-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lfindlaysap
lfindlaysap requested changes Mar 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikmace, here are my suggestions and comments.

Comment thread packages/generator-adp/src/translations/adp-generator.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/adp-generator.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/adp-generator.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/adp-generator.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/adp-generator.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/adp-generator.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/adp-generator.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/adp-generator.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/adp-generator.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/adp-generator.i18n.json Outdated
@nikmace
Copy link
Copy Markdown
Contributor Author

nikmace commented Mar 18, 2025 •
edited
Loading

@nikmace, here are my suggestions and comments.

Heya @lfindlaysap, sorry, maybe I should've made this PR a draft. All of the above text will be removed, I have yet to refactor it/decide what it's gonna be. Thanks 👍🏻

cianmSAP
cianmSAP reviewed Mar 18, 2025
View reviewed changes
Comment thread packages/generator-adp/src/app/questions/configuration.ts Outdated
@nikmace nikmace requested review from cianmSAP and devinea March 24, 2025 14:03
devinea
devinea reviewed Mar 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to axios-extension, inquirier-common look good.
Adding new generator-adp, module set-up looks good.
Changeset ✅

@cianmSAP / @IainSAP - Please review generator.

Comment thread packages/adp-tooling/test/unit/client/target-systems.test.ts Outdated
cianmSAP
cianmSAP reviewed Mar 25, 2025
View reviewed changes
Comment thread packages/adp-tooling/src/client/target-systems.ts
@nikmace nikmace requested a review from cianmSAP March 25, 2025 14:40
cianmSAP
cianmSAP previously approved these changes Mar 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New module/generator looks good
Comments addressed
Changesets look appropriate

@nikmace nikmace requested review from devinea and lfindlaysap March 26, 2025 07:22
lfindlaysap
lfindlaysap requested changes Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikmace, thanks for updating the texts. Here is my revised review based on the new changes you made.

Comment thread packages/generator-adp/src/translations/generator-adp.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/generator-adp.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/generator-adp.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/generator-adp.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/generator-adp.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/generator-adp.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/generator-adp.i18n.json Outdated
Comment thread packages/generator-adp/src/translations/generator-adp.i18n.json Outdated
@nikmace
Copy link
Copy Markdown
Contributor Author

nikmace commented Mar 26, 2025

@lfindlaysap I've pushed a commit 9058f92 with the requested changes.

@nikmace nikmace requested a review from lfindlaysap March 26, 2025 10:12
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

lfindlaysap
lfindlaysap approved these changes Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikmace, awesome 🚀. Approved.

cianmSAP
cianmSAP approved these changes Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

devinea
devinea approved these changes Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to axios-extension, inquirier-common look good.
Adding new generator-adp, module set-up looks good.
Changeset ✅

testojs
testojs approved these changes Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@testojs testojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new adaptation project generator module covering the agreed initial scope is added and looks good. It was tested manually and works as expected.

@nikmace nikmace merged commit ced5edf into main Mar 26, 2025
16 checks passed
@nikmace nikmace deleted the feat/3015/adp-generator-package branch March 26, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devinea devinea devinea approved these changes

@testojs testojs testojs approved these changes

@cianmSAP cianmSAP cianmSAP approved these changes

@lfindlaysap lfindlaysap lfindlaysap approved these changes

Assignees

@nikmace nikmace

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FEATURE - Add Adaptation Project generator

5 participants

@nikmace @devinea @testojs @cianmSAP @lfindlaysap