Skip to content

fix(ui-service-gen): hide draftEnabled for abap cds views #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 14, 2025

Conversation

docirl
Copy link
Contributor

@docirl docirl commented Mar 20, 2025

#3112

  • remove draft enabled prompt from UI Service Generator when ABAP CDS view is selected
  • update and add tests to cover new code
  • added options used to hide draftEnabled and launchAppGen prompts (other prompts are mandatory)

@docirl docirl self-assigned this Mar 20, 2025
Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: 3a3c018

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/ui-service-sub-generator Patch
@sap-ux/ui-service-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@docirl docirl marked this pull request as ready for review April 10, 2025 14:21
Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed based on conversation offline
Updates look good

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes seems clear and well covered by tests.
changeset ✅

@docirl docirl merged commit d0b2dc2 into main Apr 14, 2025
16 checks passed
@docirl docirl deleted the fix/ui-service-gen/draft-enabled-cds-views branch April 14, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants