feat: Enhance system and app prompt validations #3065
+1,849
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b7a9e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…P/open-ux-tools into feat/3015/enhance-validations
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lfindlaysap
requested changes
Apr 1, 2025
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
| "notDeployableNotFlexEnabledSystemError": "The system that you have selected is not an ABAP On-Premise system. Adaptation Project is supported only on such systems, so please choose ABAP On-Premise system which supports Flexibility and DTA_FOLDER deployment.", | ||
| "notDeployableSystemError": "The system that you have selected is not an ABAP On-Premise system which supports DTA_FOLDER deployment. Adaptation Project is supported only on such systems, so please choose ABAP On-Premise system which supports DTA_FOLDER deployment.", | ||
| "notFlexEnabledError": "The system that you have selected is not an ABAP On-Premise system which supports Flexibility. Adaptation Project is supported only on such systems, so please choose ABAP On-Premise system which supports Flexibility. If you continue, you will be able to create only an Extension Project.", | ||
| "manifestCouldNotBeValidated": "Manifest of the selected application could not be validated", |
There was a problem hiding this comment.
Suggested change
| "manifestCouldNotBeValidated": "Manifest of the selected application could not be validated", | |
| "manifestCouldNotBeValidated": "The manifest.json file of the selected application could not be validated.", |
What should users do to try to fix this error? Try again? View the logs?
There was a problem hiding this comment.
@nikmace, could you let me know if there is a solution to this error?
There was a problem hiding this comment.
packages/generator-adp/src/translations/generator-adp.i18n.json
Outdated
Show resolved
Hide resolved
|
@lfindlaysap I've updated all of the texts, you can see in the changes or in this commit: f1d13f4 |
lfindlaysap
reviewed
Apr 2, 2025
There was a problem hiding this comment.
@nikmace, thanks for making the changes. I've resolved some suggestions and commenting on the outstanding ones.
lfindlaysap
reviewed
Apr 2, 2025
| "notDeployableNotFlexEnabledSystemError": "The system that you have selected is not an ABAP On-Premise system. Adaptation projects are only supported on those systems. Please choose an ABAP On-Premise system which supports flexibility and DTA_FOLDER deployment.", | ||
| "notDeployableSystemError": "The system that you have selected is not an ABAP On-Premise system which supports DTA_FOLDER deployment. Adaptation projects are only supported on those systems. Please choose an ABAP On-Premise system which supports DTA_FOLDER deployment.", | ||
| "notFlexEnabledError": "The system that you have selected is not an ABAP On-Premise system which supports flexibility. Adaptation projects are only supported on those systems. Please choose an ABAP On-Premise system which supports flexibility. If you continue, you will only be able to create an extension project.", | ||
| "manifestCouldNotBeValidated": "Manifest of the selected application could not be validated. Select a different application.", |
There was a problem hiding this comment.
Suggested change
| "manifestCouldNotBeValidated": "Manifest of the selected application could not be validated. Select a different application.", | |
| "manifestCouldNotBeValidated": "The manifest.json file of the selected application could not be validated. Please select a different application.", |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat for #3015.