Skip to content

feat(odata service inquirer): 3059 use global filterEntitySet #3090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

korotkovao
Copy link
Contributor

#3059

globalFilterEntityType is deprecated since 1.54 of UI5 and instead globalFilterEntitySet should be used.

See the updated descriptor documentation for OVP: https://sapui5.hana.ondemand.com/#/topic/f194b411027e4402a0be0537fa7b803b

Copy link

changeset-bot bot commented Apr 7, 2025

🦋 Changeset detected

Latest commit: 29f4d1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@sap-ux/odata-service-inquirer Minor
@sap-ux/fiori-elements-writer Minor
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/fiori-app-sub-generator Patch
@sap-ux/repo-app-import-sub-generator Patch
@sap-ux/ui-service-inquirer Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/ui-service-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…ta-service-inquirer/3059/use-globalFilterEntitySet
…ta-service-inquirer/3059/use-globalFilterEntitySet
@docirl docirl marked this pull request as ready for review April 10, 2025 14:15
@docirl docirl requested review from a team as code owners April 10, 2025 14:15
lfindlaysap
lfindlaysap previously approved these changes Apr 10, 2025
@docirl docirl marked this pull request as draft April 10, 2025 14:21
@korotkovao korotkovao marked this pull request as ready for review April 11, 2025 08:56
Copy link

@korotkovao korotkovao requested a review from lfindlaysap April 23, 2025 09:38
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @korotkovao

  • Updates as expected
  • Not tested locally
  • Updates to tests for both legacy and new properties 👍

@korotkovao korotkovao merged commit afd26c8 into main Apr 23, 2025
16 checks passed
@korotkovao korotkovao deleted the feat/odata-service-inquirer/3059/use-globalFilterEntitySet branch April 23, 2025 10:04
@korotkovao
Copy link
Contributor Author

Thank you @IainSAP @lfindlaysap

devinea added a commit that referenced this pull request Apr 24, 2025
* origin/main:
  fix(cf-deploy-config-writer): remove legacy CF build task (#3073)
  chore: apply latest changesets
  fix(cf-deploy-config-writer): code changes with help from copilot (#3140)
  chore: apply latest changesets
  tbi(writers):  updates for fiori tools preview middleware & support for virtual endpoints (#3165)
  chore: apply latest changesets
  fix(cf-deploy-config-writer): refactor code to align two templates into one (#3175)
  chore: apply latest changesets
  feat(odata service inquirer): 3059 use global filterEntitySet (#3090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants