refactor: Enhance XML Fragment context menu control with addXMLPlugin Integration #3091
Conversation
🦋 Changeset detectedLatest commit: 3f6e999 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmilko01
changed the title
mmilko01
changed the title
| public init() { | ||
| this.initPlugin(); | ||
| CommunicationService.subscribe(async (action: ExternalAction): Promise<void> => { | ||
| if (addFragment.match(action)) { |
There was a problem hiding this comment.
This is probably not needed anymore, as we have generic context menu in outline that works with action service.
| @@ -132,20 +133,25 @@ export const getExtendControllerItemText = (overlay: ElementOverlay, isReuseComp | |||
| * @param syncViewsIds Ids of all application sync views | |||
| * @param ui5VersionInfo UI5 version information | |||
| */ | |||
| export const initDialogs = async (rta: RuntimeAuthoring, syncViewsIds: string[], ui5VersionInfo: Ui5VersionInfo): Promise<void> => { | |||
| export const initDialogs = async (rta: RuntimeAuthoring, syncViewsIds: string[], ui5VersionInfo: Ui5VersionInfo): Promise<Promise<void>> => { | |||
There was a problem hiding this comment.
The return type does not look right.
There was a problem hiding this comment.
Yes, this is a merging issue I missed.
Fixed in: bce4294
| }); | ||
| } else { | ||
| const addFragmentService = (await import('open/ux/preview/client/adp/add-fragment')).default; | ||
| new addFragmentService(rta).init(); |
There was a problem hiding this comment.
It looks a bit odd to create a new class instance but never actually use it. Wouldn't static methods or just initialisation function be more appropriate here.
There was a problem hiding this comment.
I agree, refactored with static methods.
Fixed in: 48efacc
…pen-ux-tools into feat/consume-addxml-plugin
…pen-ux-tools into feat/consume-addxml-plugin
…pen-ux-tools into feat/consume-addxml-plugin
mmilko01
added
preview-middleware
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
#3093
addXMLPluginis used.