-
Notifications
You must be signed in to change notification settings - Fork 43
Support Downloading ABAP Deployed Fiori App from BSP Repository #3110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d723775 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. To review these texts in a separate PR as discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New module set-up looks good.
a few small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments but looks good
packages/repo-app-download-sub-generator/src/prompts/prompts.ts
Outdated
Show resolved
Hide resolved
packages/repo-app-download-sub-generator/src/prompts/prompts.ts
Outdated
Show resolved
Hide resolved
packages/repo-app-download-sub-generator/src/prompts/prompts.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @kjose90
Comments addressed
Few follow ups needed but ok for now
Changeset looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving.
|
@sap-ux/bsp-app-download-sub-generator
axios-extension
to download base 64 encoded apps.