Fiori tools analyser - [WIP] #3805
Conversation
|
devinea
left a comment
devinea
left a comment
There was a problem hiding this comment.
New module set-up looks good.
I didn't review the /src folder in detail at this point.
…nalyser and update fast-glob version
| import type { ObjectPageAnalysis } from './object-page'; | ||
|
|
||
| export interface ManifestAnalysis { | ||
| readonly listReport?: ListReportAnalysis; |
There was a problem hiding this comment.
Could we have a type discriminated structure rather than separate properties for each type. Is it necessary to even discriminate at all here? Why not a single analysis for manifest
| } | ||
|
|
||
| export interface AnnotationAnalysis { | ||
| readonly listReport?: ListReportAnalysis; |
| import type { ObjectPageAnalysis } from './object-page'; | ||
|
|
||
| export interface ManifestAnalysis { | ||
| readonly listReport?: ListReportAnalysis; |
There was a problem hiding this comment.
| readonly listReport?: ListReportAnalysis; | |
| type: 'lrop' | 'ovp' .... | |
| commonAnalysisStuff: | |
| manfiest: Manifest // See project access (alias) type Manifest = SAPJSONSchemaForWebApplicationManifestFile |
…ate manifest handling
…nd reporting features
Bill of materials of Fiori app