feat(fiori-app-sub-generator): 36139-remove-code-assist #3860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c729ffe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lfindlaysap
previously approved these changes
Nov 24, 2025
IainSAP
reviewed
Nov 24, 2025
…of github.com:SAP/open-ux-tools into feat/fiori-app-sub-generator/36139-remove-code-assist
IainSAP
approved these changes
Nov 25, 2025
Contributor
IainSAP
left a comment
IainSAP
left a comment
There was a problem hiding this comment.
Thanks @korotkovao
- Updates as expected
- Tests updated
- Not tested lcoally
devinea
approved these changes
Nov 25, 2025
Member
devinea
left a comment
devinea
left a comment
There was a problem hiding this comment.
Thanks for the updates. Code changes lgtm.
Can you check UX_DEBUG=true UX_DEBUG_FULL=true pnpm test for FF, FE , Application and library Writers to do additional checks such as lint script on the generated projects.
lfindlaysap
approved these changes
Nov 26, 2025
|
Contributor
Author
|
Thank you All |
korotkovao
deleted the
feat/fiori-app-sub-generator/36139-remove-code-assist
branch
devinea
added a commit
that referenced
this pull request
Nov 26, 2025
* origin/main: chore: apply latest changesets feat: menu actions generator (#3521) chore: apply latest changesets chore: remove mkdirp usage and update dependencies (#3871) chore: apply latest changesets feat: save value list reference metadata (#3794) chore: apply latest changesets fix: alignment fallback ui5 versions (#3861) chore: apply latest changesets feat(fiori-app-sub-generator): 36139-remove-code-assist (#3860) chore: apply latest changesets chore - update sap-ux-odata deps (#3863)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to internal issue 36139
Do not ask the user if they want to use code assist with their generated project or not. For TypeScript, users should get this OOTB, and JavaScript support was always limited and not used.
Changes Made:
Backend Logic Removed:
Removed code assist installation logic from project generation
Preserved Backward Compatibility:
Updated Tests: