Skip to content

Conversation

@devinea
Copy link
Member

@devinea devinea commented Nov 25, 2025

Fix error:
• Application Info Settings › writeApplicationInfoSettings should add a file path to appInfo.json when mem-fs edi tor not provided

expect (jest. fn()) toHaveBeenCalledwith(• expected)
Expected: "test-file-path"
Received: "/Users/XXXXXX/git/SAPDevelop/open-ux-tools-mcp/packages/repo-app-import-sub-generator/test/test-out
put/test-app-id"

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

⚠️ No Changeset found

Latest commit: 04927b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@kjose90 kjose90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added proper test cleanup using fsPromises.rm() in beforeEach . Thanks @devinea

Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test update looks good

@sonarqubecloud
Copy link

@devinea devinea merged commit f3b475b into main Nov 27, 2025
16 checks passed
@devinea devinea deleted the fix_fiori-tools-settings-test branch November 27, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants