Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/cxcds 14098 - fix for backwards compatibilty #19995

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Bugfix/cxcds 14098 - fix for backwards compatibilty #19995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c6468a
CXCDS-14098: Add sciEnabled and siteId value to profiletag config as …
johannathalmann-SAP Feb 17, 2025
4cae9f6
CXCDS-14098: Remove accidentally committed code.
johannathalmann-SAP Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions integration-libs/cds/src/config/profile-tag.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
export interface ProfileTagConfig {
javascriptUrl?: string;
configUrl?: string;
siteId?: string;
allowInsecureCookies?: boolean;
gtmId?: string;
sciEnabled?: boolean;
}
9 changes: 6 additions & 3 deletions integration-libs/cds/src/schematics/add-cds/__snapshots__/index_spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ import { I18nConfig, provideConfig } from "@spartacus/core";
'profile-tag-load-url.com',
configUrl:
'profile-tag-config-url.com',
allowInsecureCookies: true
allowInsecureCookies: true,
sciEnabled: false
},
},
})
Expand Down Expand Up @@ -86,7 +87,8 @@ import { I18nConfig, provideConfig } from "@spartacus/core";
'profile-tag-load-url.com',
configUrl:
'profile-tag-config-url.com',
allowInsecureCookies: true
allowInsecureCookies: true,
sciEnabled: true
},
},
})
Expand Down Expand Up @@ -134,7 +136,8 @@ import { I18nConfig, provideConfig } from "@spartacus/core";
'PROFILE_TAG_LOAD_URL_PLACEHOLDER',
configUrl:
'PROFILE_TAG_CONFIG_URL_PLACEHOLDER',
allowInsecureCookies: true
allowInsecureCookies: true,
sciEnabled: false
},
},
})
Expand Down
3 changes: 2 additions & 1 deletion projects/schematics/src/shared/lib-configs/integration-libs/cds-schematics-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ function buildCdsConfig(
options.profileTagConfigUrl ||
'PROFILE_TAG_CONFIG_URL_PLACEHOLDER'
}',
allowInsecureCookies: true
allowInsecureCookies: true,
sciEnabled: ${options.sciEnabled}
},
},
}`,
Expand Down
Loading