Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicPage: ARIA attributes must conform to valid values - [a11y issue] #10987

Closed
1 task done
techie-khushdeep opened this issue Feb 28, 2025 · 2 comments · Fixed by #11033
Closed
1 task done

DynamicPage: ARIA attributes must conform to valid values - [a11y issue] #10987

techie-khushdeep opened this issue Feb 28, 2025 · 2 comments · Fixed by #11033
Assignees
@NakataCode
Labels
Medium Prio TOPIC P

Comments

@techie-khushdeep
Copy link

Describe the bug

We are using the DynamicPage component in our application. We are getting a11y issue - ARIA attributes must conform to valid values.

Here is the screenshots:

Image

Image

Isolated Example

https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/layouts-floorplans-dynamicpage--docs

Reproduction steps

  1. Open the component: https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/layouts-floorplans-dynamicpage--docs
  2. Run a11y issue scan using browser extension axe dev tools

Expected Behaviour

Component should not give any a11y issue.

Screenshots or Videos

No response

UI5 Web Components for React Version

2.5.0

UI5 Web Components Version

2.5.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output



Organization


SAP


Declaration


    

  •  I’m not disclosing any internal or sensitive information.
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            


    







      

  
      



  

  @Lukas742





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

      

      
            Lukas742
  

      

      

      commented


        Mar 3, 2025


      
    


  





      


        


  
    

      
          
Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @Lukas742
Lukas742




        transferred this issue from SAP/ui5-webcomponents-react


      Mar 3, 2025

    

  



    

    

      
    

    


      

          @Todor-ads
Todor-ads




              self-assigned this


      Mar 5, 2025

    

  



    


    


    







      

  
      



  

  @Todor-ads





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Hello @SAP/ui5-webcomponents-topic-p,

could you please check this issue?

Thanks,

Todor

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @Todor-ads
Todor-ads




              removed their assignment


      Mar 6, 2025

    

  



    

    

      
    

    


      

          @NakataCode
NakataCode




              self-assigned this


      Mar 7, 2025

    

  



    

    

      
    

    


      

          @NakataCode
NakataCode




          moved this from Issues
  to In Progress
  in Maintenance - Topic P


      Mar 7, 2025

    

  



  

  

    
  


  

      

    @NakataCode
NakataCode



    mentioned this issue
    
      Mar 7, 2025
    





  


  

      
   Merged

  







  




    


    

    


    

    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this from In Progress
  to Completed
  in Maintenance - Topic P


      Apr 2, 2025

    

  



  
  


  
    
  
  

    
  s-todorova 

      pushed a commit
      that referenced
      this issue

    
      Apr 9, 2025
    
    

      


  

    

      


  

      
        @NakataCode
      
        @s-todorova
  





      

        
          fix(ui5-dynamic-page): validate aria-controls reference before render…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          5221626
        
      

    

  

    

      
…ing (#11033)

Problem:
Invalid ARIA attributes were being generated when the referenced header element wasn't available with the exact ID.

Solution:
Remove _accAttributesForHeaderActions because the header and the (pin/unpin/expand/collapse) actions exist in separate shadow DOMs.

Fixes: #10987

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @NakataCode
  
    NakataCode
    

      








      


  


  

    Labels
  



    

      

    Medium Prio

  

    TOPIC P









      

  

    

        

    Projects
  


        




        
  

    

      
          
        Maintenance - Topic P
    

    

      

            
    Status: Completed


      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  




            
  
Successfully merging a pull request may close this issue.





    


  
          
      fix(ui5-dynamic-page): validate aria-controls reference before rendering

    
      SAP/ui5-webcomponents
    





      
    

  




      

    

  
      

  

    

      4 participants
    

    

        
          @techie-khushdeep 
        
          @Lukas742 
        
          @Todor-ads 
        
          @NakataCode