Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-table): single and multi selection components added #10897

Merged
merged 3 commits into from
Feb 21, 2025
Merged

feat(ui5-table): single and multi selection components added #10897

merged 3 commits into from
Feb 21, 2025

Conversation

aborjinik
Copy link
Contributor

@aborjinik aborjinik commented Feb 19, 2025 •
edited
Loading

  • dedicated selection components ui5-table-selection-single and ui5-table-selection-multi are added
  • old ui5-table-selection component is deprecated

Fixes: #9677

@aborjinik aborjinik requested review from KvM2 and DonkeyCo February 19, 2025 11:57
DonkeyCo
DonkeyCo reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@DonkeyCo DonkeyCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this so far. Makes the selection specific stuff way cleaner. Let's wait for the docs review and then this should be ready for shipping

KvM2
KvM2 reviewed Feb 21, 2025
View reviewed changes
@aborjinik aborjinik force-pushed the table-selection-split branch from 4410585 to 08a6fe5 Compare February 21, 2025 11:44
yanaminkova and others added 3 commits February 21, 2025 15:19
@yanaminkova @aborjinik
feat(ui5-table): single and multi selection components added
1c4e480
@aborjinik
feat(ui5-table): single and multi selection components added
4a55326 
- Documentation and test update

Fixes: #9677
@aborjinik
feat(ui5-table): single and multi selection components added
d2f5f24 
- Documentation and test update
- Tables selection tests are moved to the TableSelection files

Fixes: #9677
@aborjinik aborjinik force-pushed the table-selection-split branch from 08a6fe5 to d2f5f24 Compare February 21, 2025 14:19
@aborjinik aborjinik merged commit f3b069c into main Feb 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KvM2 KvM2 KvM2 left review comments

@DonkeyCo DonkeyCo DonkeyCo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TableSelection: include selected row/s in change event
4 participants
@aborjinik @DonkeyCo @KvM2 @yanaminkova