Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-tokenizer): hide visually hidden text from screen reader #10918

Open
wants to merge 1 commit into
base: release-1.24
Choose a base branch
from
Open

fix(ui5-tokenizer): hide visually hidden text from screen reader #10918

wants to merge 1 commit into from

Conversation

Okiana
Copy link
Contributor

@Okiana Okiana commented Feb 20, 2025

Fixes: #10361

elenastoyanovaa
elenastoyanovaa reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"hide visually hidden text from screen reader" is better, as the double announcement is actually not reproducible on our side

@Okiana Okiana changed the title fix(ui5-tokenizer): prevent twice announcing of tokenizer fix(ui5-tokenizer): hide visually hidden text from screen reader Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenastoyanovaa elenastoyanovaa elenastoyanovaa left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Okiana @elenastoyanovaa