refactor(ui5-side-navigation): remove "design" property #11219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ui5-side-navigation component by removing the "design" property and its associated enum, with the intent that decorations are now set by the layout.
- Removed the SideNavigationDesign enum from the types file.
- Removed the "design" property from the SideNavigation component.
Reviewed Changes
Copilot reviewed 2 out of 19 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/fiori/src/types/SideNavigationDesign.ts | Removed the SideNavigationDesign enum completely. |
| packages/fiori/src/SideNavigation.ts | Removed the "design" property and its documentation. |
Files not reviewed (17)
- packages/fiori/src/themes/NavigationLayout.css: Language not supported
- packages/fiori/src/themes/SideNavigation.css: Language not supported
- packages/fiori/src/themes/base/NavigationLayout-parameters.css: Language not supported
- packages/fiori/src/themes/sap_fiori_3/parameters-bundle.css: Language not supported
- packages/fiori/src/themes/sap_fiori_3_dark/parameters-bundle.css: Language not supported
- packages/fiori/src/themes/sap_fiori_3_hcb/parameters-bundle.css: Language not supported
- packages/fiori/src/themes/sap_fiori_3_hcw/parameters-bundle.css: Language not supported
- packages/fiori/src/themes/sap_horizon/NavigationLayout-parameters.css: Language not supported
- packages/fiori/src/themes/sap_horizon/parameters-bundle.css: Language not supported
- packages/fiori/src/themes/sap_horizon_dark/NavigationLayout-parameters.css: Language not supported
- packages/fiori/src/themes/sap_horizon_dark/parameters-bundle.css: Language not supported
- packages/fiori/src/themes/sap_horizon_hcb/NavigationLayout-parameters.css: Language not supported
- packages/fiori/src/themes/sap_horizon_hcb/parameters-bundle.css: Language not supported
- packages/fiori/src/themes/sap_horizon_hcw/NavigationLayout-parameters.css: Language not supported
- packages/fiori/src/themes/sap_horizon_hcw/parameters-bundle.css: Language not supported
- packages/fiori/test/pages/SideNavigationOverlay.html: Language not supported
- packages/website/docs/_samples/fiori/SideNavigation/OverlayMode/sample.html: Language not supported
s-todorova
approved these changes
Mar 31, 2025
Stoev
reviewed
Mar 31, 2025
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decorations of the
ui5-side-navigationare now set by the layout.