fix(ui5-calendar): show year range in YearPicker header #11450
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unazko
reviewed
May 2, 2025
There was a problem hiding this comment.
There is a difference between the displayed years in the year grid and those in the header:
Case 1:
<ui5-date-picker format-pattern="yyyy"></ui5-date-picker>
Steps:
- Open the picker
- Select a year
- Reopen the picker
Case 2:
<ui5-date-picker secondary-calendar-type='Buddhist'></ui5-date-picker>
(The same is also reproducible with secondary-calendar-type='Japanese')
Steps:
- Open the year picker view
Also the year range text in the header appears to be bolded in the sap_horizon theme whereas in the sap_horizon_hcw for example it is not.
|
Done in another change. Test cases mentioned in the comment were tested and are okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Year range is now shown in the header in YearPicker view. Currently it is not interactive, that will be introduced in change #11167. Text color for years in secondary calendar type is now correct as well.
fixes: #11011