Skip to content

Integration of LArSoft v10 geometry, vetted [2/2]#808

Merged
leoaliaga merged 10 commits intodevelopfrom
geom-separate
Mar 3, 2025
Merged

Integration of LArSoft v10 geometry, vetted [2/2]#808
leoaliaga merged 10 commits intodevelopfrom
geom-separate

Conversation

@PetrilloAtWork
Copy link
Member

@PetrilloAtWork PetrilloAtWork commented Feb 28, 2025

This branch is the merge of the proposed geom-separate by @knoepfel and ICARUS changes, and it supersedes PR #642.

I "self-approve" ✔️ the PR as it is the result of the review of PR #642. However, a formal approval is required by GitHub.

This PR depends on SBNSoftware/icarusalg#92.

@leoaliaga
Copy link
Contributor

trigger build SBNSoftware/icarusalg#92 LArSoft/lar*@LARSOFT_SUITE_v10_04_04

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@leoaliaga
Copy link
Contributor

trigger build SBNSoftware/icarusalg#92 LArSoft/lar*@LARSOFT_SUITE_v10_04_04

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

Copy link
Contributor

@jzennamo jzennamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I enthusiastically approve!

@leoaliaga leoaliaga merged commit 3c0a8ab into develop Mar 3, 2025
3 of 4 checks passed
@leoaliaga leoaliaga deleted the geom-separate branch March 3, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants