Conversation
|
This is a set of PRs that spans SBNSoftware/sbnana#89, SBNSoftware/sbncode#298, and SBNSoftware/sbnobj#67 |
| unsigned int fno; ///< Index of file processed by CAFMaker | ||
| unsigned int ngenevt; ///< Number of events generated in input file associated with this record (before any filters) | ||
| float pot; ///< POT of the subrun associated with this record | ||
| float extcount; |
There was a problem hiding this comment.
It looks like the number of "beam gates" is missing, which would be needed to normalize "extcount" to "pot".
Also, it looks like "extcount" is missing a comment describing it.
| isMajority(false), | ||
| isMinBias(false) |
There was a problem hiding this comment.
These should be commented what they mean or their name should be changed to something more generic.
| bool isMajority; | ||
| bool isMinBias; |
There was a problem hiding this comment.
These should be commented what they mean or their name should be changed to something more generic.
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
There was a problem hiding this comment.
Fortunately the integration test caught the error somehow...
This commit is trying to redefine the checksum of caf::SRHeader version 17 which was previously there. This must not be, since version 17 was seen in a release and data may have been produced with it.
A new version 18 should be added instead:
<class name="caf::SRHeader" ClassVersion="18">
<version ClassVersion="18" checksum="2118058550"/>
<version ClassVersion="17" checksum="2390355049"/>
4 participants
Added offbeam gate counting in CAFs adding a similar object to what is added for BNB and NuMI spill accounting. Looks at the number of gates for BNB and NuMI offbeam alone for offbeam data which event-by-event is computed as the difference in the number of gates for the previous event.