Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the release workflow to reinstate platform-specific packaging and adjusts build-trigger paths by removing the legacy cross-build workflow.
- Restores detailed
release.ymljobs for macOS (arm64/x64), various Windows backends (CPU, CUDA, SYCL, HIP), and iOS. - Updates
build.ymlpath filters to drop references to the removed cross-compilation workflow. - Deletes the obsolete
build-linux-cross.ymlfile.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release.yml | Re-added platform-specific release jobs and updated job dependencies |
| .github/workflows/build.yml | Adjusted GitHub Actions path filters for build triggers |
| .github/workflows/build-linux-cross.yml | Removed legacy cross-compilation workflow |
Comments suppressed due to low confidence (3)
.github/workflows/release.yml:24
- [nitpick] The macOS-arm64 and macOS-x64 jobs share nearly identical steps; consider consolidating them into a single matrix to reduce duplication and simplify maintenance.
macOS-arm64:
.github/workflows/release.yml:267
- [nitpick] The fallback value
'win64a'for ARM64 may be unclear—verify that this is the intended identifier for your curl setup action, or consider renaming for clarity.
architecture: ${{ matrix.arch == 'x64' && 'win64' || 'win64a' }}
.github/workflows/release.yml:560
- PowerShell does not expand wildcards inside single-quoted paths, so this invocation will fail. Use
Get-ChildItemor resolve the exact ROCm path before callingclang.exe.
& 'C:\Program Files\AMD\ROCm\*\bin\clang.exe' --version
| - name: Build | ||
| id: cmake_build | ||
| run: | | ||
| sysctl -a |
There was a problem hiding this comment.
Running sysctl -a prints all system parameters and clutters the logs; consider removing it or narrowing the output to only necessary fields.
Suggested change
| sysctl -a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert release.yml