Support Databricks query tags in session properties#5794
Conversation
ad8c237 to
d9881ce
Compare
|
Will fix the failing style tests. |
Signed-off-by: Christian Troelsen <christian.troelsen@tryg.dk>
d9881ce to
17b3af7
Compare
|
@izeigerman Perhaps you can have a look at this 😄 ? |
|
@WhammyLeaf Can you rebase your branch? Then I'll kick off the workflows and give it a review! |
Should be done now 😄 |
|
@WhammyLeaf Just gave it a review, and these are not blockers but curious your thoughts:
Let me know if I'm missing anything! |
@StuffbyYuki This sounds about right. I have added both load-time validation, model-level tests and documentation now 😄 |
|
@WhammyLeaf Thanks for the changes! The last thing is the DCO checks, and once all CI tests pass I'll merge |
Description
The Databricks SQL connector supports per-statement
query_tags, but SQLMesh did not previously pass model/session-levelsession_properties.query_tagsthrough to the connector. This change stores validated query tags for the active adapter session and forwards them to Databricks SQL connector executions.Query tags are only applied on the Databricks SQL connector path. They are not passed when execution is routed through Spark session / Databricks Connect paths, since those cursors do not support the
query_tagsargument.ISSUE: #5795
Test Plan
query_tagsNULLquery tag valuessession_properties.query_tagsCursor.execute(..., query_tags=...).