Skip to content

fix(dlt): prevent credential type field overwriting db_type in format_config #5857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mary-mt wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −4
Draft

fix(dlt): prevent credential type field overwriting db_type in format_config #5857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f3b7ea
fix(dlt): prevent credential type field overwriting db_type in format…
mary-mt Jun 23, 2026
b927e56
test(dlt): reorder connection fields in test_dlt_pipeline
mary-mt Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions sqlmesh/integrations/dlt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,7 @@ def generate_incremental_model(

def format_config(configs: t.Dict[str, str], db_type: str) -> str:
"""Generate a string for the gateway connection config."""
config = {
"type": db_type,
}
config: t.Dict[str, t.Any] = {}

for key, value in configs.items():
if key == "password":
Expand All @@ -226,6 +224,11 @@ def format_config(configs: t.Dict[str, str], db_type: str) -> str:
else:
config[key] = value

# Set db_type after iterating credentials so that credential attributes
# with a conflicting name (e.g. GCP service-account JSON contains
# "type": "service_account") cannot overwrite the connection type.
config["type"] = db_type

# Validate the connection config fields
invalid_fields = []
try:
Expand Down
2 changes: 1 addition & 1 deletion tests/cli/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,8 +1020,8 @@ def test_dlt_pipeline(runner, tmp_path):
gateways:
duckdb:
connection:
type: duckdb
database: {dataset_path}
type: duckdb
default_gateway: duckdb

# --- Model Defaults ---
Expand Down