fix: Set DatabricksConnectionConfig to only use a shared_connection with U2M OAuth#5859
Open
davem-bis wants to merge 2 commits into
Conversation
…hen U2M OAuth authentication is used. Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
…databricks-access-token-connections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The DatabricksConnectionConfig was set to use a shared connection pool for all authentication types to resolve a race condition with U2M OAuth, however this has the side effect that SQL execution is sequential regardless of the
concurrent_tasksconfig setting.This change updates:
shared_connectionvariable to be a computed field for allConnectionConfigclasses.shared_connectionvariable to returnTrueonly for U2M OAuth authentication methods for theDatabricksConnectionConfigclass.Partially resolves #5858.
Test Plan
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO