💄 Added icons next to sidebar titles #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaaclombardssw
requested changes
Jan 2, 2025
lib/components/MegaIcon/MegaIcon.tsx
Outdated
| @@ -22,12 +23,14 @@ export interface MegaIconProps { | |||
| // TODO: implement below intended solution extends React.ComponentPropsWithoutRef<"span"> { | |||
| iconImg?: string; | |||
| icon?: AvailableIcons; | |||
| imgSize?: "small" | "medium"; | |||
There was a problem hiding this comment.
I would also move this into the constants if we're designing things like that.
ex. ICON_IMAGE_SIZE_OPTIONS = ["small", "medium"]
There was a problem hiding this comment.
Done - I moved icon sizes into it's own separate type
Calinator444
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the megamenu with a prop that can he used to add icons next to the heading in the sidebar menu groups
Screenshots
Figure: Sidebar menu heading using one of the svgs in the project as an icon
Figure: Sidebar menu using an external image as the icon