Skip to content

Conversation

rewenila
Copy link
Contributor

@rewenila rewenila commented Sep 29, 2025

Skip tests/test_metadata.py::test_url for AI containers. This test fails for the vLLM containers (vllm-openai, lmcache-vllm-openai, lmcache-lmstack-router), as the application URL doesn't match the container name:

FAILED tests/test_metadata.py::test_url[container89-lmcache-lmstack-router-application] - AssertionError: expected LABEL com.suse.application.lmcache-lmstack-router.url = ('https://apps.rancher.io/applications/lmcache-lmstack-router', 'https://apps.rancher.io/applications/lmcache-lmstack') but is https://apps.rancher.io/applications/vllm
assert 'https://apps.rancher.io/applications/vllm' in ('https://apps.rancher.io/applications/lmcache-lmstack-router', 'https://apps.rancher.io/applications/lmcache-lmstack')

[CI:TOXENVS] ai

@dirkmueller
Copy link
Member

dirkmueller commented Sep 30, 2025

@rewenila rather than reducing test coverage, would it be possible to fix the definition in

"lmcache-lmstack-router",
instead or is there any downside of that I don't see?

@rewenila
Copy link
Contributor Author

I thought the definition there should match the name in the image label. Won't other tests fail if I change it? Maybe I'm missing something.

I could also skip the url test for the vLLM containers only, instead of for all the AI containers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants