Skip to content

Added tests for running nginx and valkey as a non root user #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added tests for running nginx and valkey as a non root user #922

wants to merge 1 commit into from

Conversation

rcmadhankumar
Copy link
Contributor

[CI:TOXENVS] nginx,valkey

alexandrevicenzi
alexandrevicenzi reviewed Oct 13, 2025
View reviewed changes
alexandrevicenzi
alexandrevicenzi requested changes Oct 14, 2025
View reviewed changes
Copy link
Member

@alexandrevicenzi alexandrevicenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing for code style.

@rcmadhankumar
Copy link
Contributor Author

I think code style failure is not due to the this PR specific changes.

madhan@localhost:~/repo/runroot-tests/ngin/BCI-tests> tox -e lint | grep valk
madhan@localhost:~/repo/runroot-tests/ngin/BCI-tests> tox -e lint | grep nginx
madhan@localhost:~/repo/runroot-tests/ngin/BCI-tests>

it was showing score of 9.69/10 and failing.

@alexandrevicenzi
Copy link
Member

I think code style failure is not due to the this PR specific changes.

madhan@localhost:~/repo/runroot-tests/ngin/BCI-tests> tox -e lint | grep valk
madhan@localhost:~/repo/runroot-tests/ngin/BCI-tests> tox -e lint | grep nginx
madhan@localhost:~/repo/runroot-tests/ngin/BCI-tests>

it was showing score of 9.69/10 and failing.

Maybe #923 fixes the linter errors.

@dirkmueller dirkmueller self-requested a review October 14, 2025 13:04
dirkmueller
dirkmueller reviewed Oct 14, 2025
View reviewed changes
Copy link
Member

@dirkmueller dirkmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing now..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dirkmueller dirkmueller dirkmueller left review comments

@alexandrevicenzi alexandrevicenzi alexandrevicenzi requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rcmadhankumar @alexandrevicenzi @dirkmueller