Changes in SUMA integration #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomschr
requested changes
Nov 4, 2024
This PR must be reviewed but cannot be merged/published until the new version of Trento is out. It describes the second iteration of the integration of Trento with SUSE Manager, by which we can see the list of available patches and upgradable packages for each registered host that is also managed by SUMA.
tomschr
force-pushed
the
abravosuse-changes-in-suma-integration
branch
from
7da187c
to
53d630c
Compare
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
Co-authored-by: Tom Schraitle <[email protected]>
abravosuse
commented
Nov 4, 2024
There was a problem hiding this comment.
@tomschr missing file uploaded. All other suggestions accepted AS-IS. Thank you!
dmpop
reviewed
Nov 7, 2024
Comment on lines
+1797
to
+1798
| <para>Clicking on the <guimenu>Upgradable Packages</guimenu> box takes us to the <guimenu>Upgradable Package</guimenu> overview, | ||
| where the user can see the list of packages that can be upgraded in that particular host:</para> |
There was a problem hiding this comment.
Suggested change
| <para>Clicking on the <guimenu>Upgradable Packages</guimenu> box takes us to the <guimenu>Upgradable Package</guimenu> overview, | |
| where the user can see the list of packages that can be upgraded in that particular host:</para> | |
| <para>Click <guimenu>Upgradable Packages</guimenu> to open the <guimenu>Upgradable Package</guimenu> overview containing a list of packages that can be upgraded on that particular host:</para> |
There was a problem hiding this comment.
Suggested change
| <para>Clicking on the <guimenu>Upgradable Packages</guimenu> box takes us to the <guimenu>Upgradable Package</guimenu> overview, | |
| where the user can see the list of packages that can be upgraded in that particular host:</para> | |
| <para>Click <guimenu>Upgradable Packages</guimenu> to open the <guimenu>Upgradable Packages</guimenu> overview containing a list of packages that can be upgraded on that particular host:</para>> |
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
abravosuse
commented
Nov 7, 2024
There was a problem hiding this comment.
Thanks for the suggestions @dmpop . Just a small change request from my side: Upgradable Package > Upgradable Packages.
Comment on lines
+1797
to
+1798
| <para>Clicking on the <guimenu>Upgradable Packages</guimenu> box takes us to the <guimenu>Upgradable Package</guimenu> overview, | ||
| where the user can see the list of packages that can be upgraded in that particular host:</para> |
There was a problem hiding this comment.
Suggested change
| <para>Clicking on the <guimenu>Upgradable Packages</guimenu> box takes us to the <guimenu>Upgradable Package</guimenu> overview, | |
| where the user can see the list of packages that can be upgraded in that particular host:</para> | |
| <para>Click <guimenu>Upgradable Packages</guimenu> to open the <guimenu>Upgradable Packages</guimenu> overview containing a list of packages that can be upgraded on that particular host:</para>> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR must be reviewed but cannot be merged/published until the new version of Trento is out. It describes the second iteration of the integration of Trento with SUSE Manager, by which we can see the list of available patches and upgradable packages for each registered host that is also managed by SUMA.
PR creator: Description
Describe the overall goals of this pull request.
PR creator: Are there any relevant issues/feature requests?