Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix secrets file access mode #1062

Closed
wants to merge 15 commits into from
Closed

Fix secrets file access mode #1062

wants to merge 15 commits into from

Conversation

ngetahun
Copy link
Contributor

@ngetahun ngetahun commented Jan 3, 2024 •
edited
Loading

Description

Set group readable permissions to rails credentials file.

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have verified that my code follows RMT's coding standards with rubocop.
  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • RMT's test coverage remains at 100%.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Other Notes

Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes.

ngetahun and others added 12 commits December 14, 2023 11:22
@ngetahun
WIP: Add ssl parsing config keys
8d4670d
@ngetahun
Set secret key file mode during fresh installation
8cfa26f
@felixsch @ngetahun
Moved repomd parser implementation out of the way
09a5a15
@felixsch @ngetahun
Detect repository types when mirroring repositories
15b4a37
@felixsch @ngetahun
Make repomd specs green
93b546c
@felixsch @ngetahun
Make import/export and mirror cli commands green
95c03e1
@mssola @ngetahun
support: migrated to supportconfig.rc
bcd2522 
ALP will not support the deprecated scplugin.rc framework. This commit,
then, migrates our support script to work with supportconfig.rc.

This patch has been originally contributed by Jason Record on the linked
Bugzilla entry.

Fixes bsc#1216389

Signed-off-by: Miquel Sabaté Solà <[email protected]>
@felixsch @ngetahun
Authenticate repository detection calls if needed
5bce7dc
@digitaltom @ngetahun
Include id of existing repository in error message
6b136f6
@digitaltom @ngetahun
add logs when loading data from SCC
cf22bd5
@digitaltom @ngetahun
update repo url from scc data on sync (bsc#1218243)
f8f959e
@ngetahun
Revert "WIP: Add ssl parsing config keys"
f128660 
This reverts commit 8d4670d.
@ngetahun ngetahun force-pushed the fix_secrets_file_access_mode branch from a0bf63b to f128660 Compare January 3, 2024 16:32
@SUSE SUSE deleted a comment from suse-tests-pass Jan 3, 2024
@SUSE SUSE deleted a comment from suse-tests-pass Jan 4, 2024
@felixsch felixsch mentioned this pull request Jan 4, 2024
Merged
@SUSE SUSE deleted a comment from suse-tests-pass Jan 4, 2024
@SUSE SUSE deleted a comment from suse-tests-pass Jan 4, 2024
@SUSE SUSE deleted a comment from suse-tests-pass Jan 4, 2024
@felixsch
Copy link
Contributor

felixsch commented Jan 4, 2024

fixed here: #1064
and feature removed here: #1065

@felixsch felixsch closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ngetahun @felixsch @mssola @digitaltom