feat(button): use DS background token for contrast#8059
Open
tamas-sage wants to merge 2 commits into
Open
Conversation
DipperTheDan
approved these changes
Jul 3, 2026
edleeks87
approved these changes
Jul 3, 2026
edleeks87
requested changes
Jul 9, 2026
edleeks87
left a comment
Contributor
There was a problem hiding this comment.
@tamas-sage apologies I've just realised this has a feat commit which will trigger a release which we don't need for this change. Either chore/docs/refactor will be better for this
divyajindel
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
In Button/Test -> AllSizesVariantsTypes, some button groups (including secondary destructive examples) are rendered on hardcoded grey backgrounds (#DDDDDD). This can produce contrast failures and does not represent an official DS background token.


Current behaviour
Use Design System background tokens in the story (e.g. var(--mode-color-generic-bg-nought)) instead of hardcoded greys, so contrast checks run against approved DS colors and reflect intended design usage.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions