Refactoring Branch#79

Draft

lucas-wilkins wants to merge 475 commits intomasterfrom

refactor_24

This pull request is big! We're only showing the most recent 250 commits

Commits on Feb 18, 2026

Process can have multiple terms, which may be quantites
rprospero
committed
Fix hdf process term parsing
rprospero
committed
Correctly parse process notes
rprospero
committed
Add type hint to load_data filename
rprospero
committed
More concise source parsing
rprospero
committed
Whitespace fix
rprospero
committed
Typehint on load_data
rprospero
committed
Fix up Source parser
rprospero
committed
Add raw data to xml metadata
rprospero
committed
Add raw handling to reader
rprospero
committed
Enable raw data filter
rprospero
committed
Start testing data filter
rprospero
committed
Run through code formatter
rprospero
committed
Simplify metadata filtering
rprospero
committed
Raise KeyError instead of ValueError
rprospero
committed
Fix up ascii reader tests
rprospero
committed
Update creation of SasData in trend
rprospero
committed
Properly compare named units with unnamed units
rprospero
committed
Enforce loading test reference files in UTF-8
rprospero
committed
Skeleton framework for SESANS data
rprospero
committed
Start parsing sesans header
rprospero
committed
Start parsing SESANS sample metadata
rprospero
committed
Include SESANS angle metadata
rprospero
committed
Multiple SESANS files in reader test
rprospero
committed
Parse actual data from SES files
rprospero
committed
Add Raw SESANS Node Data
rprospero
committed
Update XML test references to include apertures
rprospero
committed
SESANS metadata as a process, not an aperture
rprospero
committed
Fixup lint
rprospero
committed
Make changes suggested in PR review
rprospero
committed
Fix simple typos from rebase
rprospero
committed
Add equality testing for quantities
rprospero
committed
More tests for quantities
rprospero
committed
Fix meshmerge calculation
rprospero
committed
Ruff format.

jamescrake-merani
authored and
rprospero
committed
This comment was repetitive.

jamescrake-merani
authored and
rprospero
committed
Ruff format.

jamescrake-merani
authored and
rprospero
committed
Function to guess the dataset type.

jamescrake-merani
authored and
rprospero
committed
Function for loading a file with default params.

jamescrake-merani
authored and
rprospero
committed
Ruff format.

jamescrake-merani
authored and
rprospero
committed
Remove imports ruff is complaining aren't used.

jamescrake-merani
authored and
rprospero
committed
Added a test to make sure 2d data gets read right.

jamescrake-merani
authored and
rprospero
committed
Makes sure the dataset type gets guessed.

jamescrake-merani
authored and
rprospero
committed
Use basename for sasdata ascii name.

jamescrake-merani
authored and
rprospero
committed
Be consistent with how basename is called.

jamescrake-merani
authored and
rprospero
committed
Move comment to avoid odd Ruff format.

jamescrake-merani
authored and
rprospero
committed
Move comment again.

jamescrake-merani
authored and
rprospero
committed
Fixed test.

jamescrake-merani
authored and
rprospero
committed
Created an import metadata function.

jamescrake-merani
authored and
rprospero
committed
Remove the old function.

jamescrake-merani
authored and
rprospero
committed
Use the new import function.

jamescrake-merani
authored and
rprospero
committed
Remove these imports.

jamescrake-merani
authored and
rprospero
committed
Need to use keywords for this dataclass.

jamescrake-merani
authored and
rprospero
committed
Import the mumag data for testing.

jamescrake-merani
authored and
rprospero
committed
Added a case for mumag data.

jamescrake-merani
authored and
rprospero
committed
Added test for loading ascii data with metadata.

jamescrake-merani
authored and
rprospero
committed
Use params filenames not just filenames.

jamescrake-merani
authored and
rprospero
committed
Fixed column parameters.

jamescrake-merani
authored and
rprospero
committed
Doh. Missing commas on filename list.

jamescrake-merani
authored and
rprospero
committed
Roll the raw metadata into the metadata object.

jamescrake-merani
authored and
rprospero
committed
Need to fill in all the parameters.

jamescrake-merani
authored and
rprospero
committed
Forgot process :P

jamescrake-merani
authored and
rprospero
committed
Consider both of these.

jamescrake-merani
authored and
rprospero
committed
Combine both metadata so we go through all of them

jamescrake-merani
authored and
rprospero
committed
Raw metadata is in lists.

jamescrake-merani
authored and
rprospero
committed
I don't know what these decimals were.

jamescrake-merani
authored and
rprospero
committed
Start implementing ModellingRequirements
rprospero
committed
Start testing modelling requirements
rprospero
committed
Start adding better tests for ModellingRequirements
rprospero
committed
Flip order of parameters on compose
rprospero
committed
Don't assume that Sesans includes smear
rprospero
committed
Enable left composition by null model
rprospero
committed
support right addition of NullModel
rprospero
committed
Allow preprocess and postprocess steps
rprospero
committed
Start performing Hankel transform for SESANS
rprospero
committed
Ignore slit smearing before SESANS
rprospero
committed
Pull sesans metadata from file
rprospero
committed
Add unit test for Hankel transform
rprospero
committed
Fix units with error calculation
rprospero
committed
χ² squared based test
rprospero
committed
Code Review Suggestions
rprospero
committed
Fix up rename in compose
rprospero
committed
Fix uncertainty in SESANS parser
rprospero
committed
Update SESANS units in unit_kinds
rprospero
committed
Applies auto fixes for ruff rule F401

DrPaulSharp
authored and
rprospero
committed
Applies auto fixes for ruff rule E714

DrPaulSharp
authored and
rprospero
committed
Applies auto fixes for ruff rule F541

DrPaulSharp
authored and
rprospero
committed
Test should fail when there's no data.

James Crake-Merani
authored and
rprospero
committed
Added a get default unit function.

James Crake-Merani
authored and
rprospero
committed
Use the new get default unit function.

James Crake-Merani
authored and
rprospero
committed
Pass in the unit group as well.

James Crake-Merani
authored and
rprospero
committed
Return value if it isn't None.

James Crake-Merani
authored and
rprospero
committed
Set the dataset type properly.

James Crake-Merani
authored and
rprospero
committed
Expect 2D test to fail.

James Crake-Merani
authored and
rprospero
committed
Use Quantity in models
rprospero
committed
Don't use a quantity for model post processing
rprospero
committed
Basic Pinhole model
rprospero
committed
Refactor pinhole tests
rprospero
committed
Fix radius bug in smearing
rprospero
committed
More realisting δq
rprospero
committed
Combine Smearing and Sesans tests
rprospero
committed
Define model metadata in constructor
rprospero
committed
Better testing range for pinhole
rprospero
committed
Add slit smearing
rprospero
committed
Remove old commented code
rprospero
committed
Vectorise slit calculation
rprospero
committed
Check combination of slit models
rprospero
committed
Decrease logical depth of linear_extrapolation
rprospero
committed
Decrease logical depth of slit_resolution
rprospero
committed
Decrease logical depth of geometric_extrapolation
rprospero
committed
Apply PR changes
rprospero
committed
Fixes ruff linting errors (#140)

DrPaulSharp
authored and
rprospero
committed
Adds Pyupgrade (UP) ruleset and rules SIM118 & SIM300 to ruff linter (#144)

DrPaulSharp
authored and
rprospero
committed
Applies fixes for isort (I) ruff ruleset (#146)

DrPaulSharp
authored and
rprospero
committed
Fixes whitespace errors

DrPaulSharp
authored and
rprospero
committed
Fix hours, days, and years
rprospero
committed
Add command for explicitly formatting quantity units
rprospero
committed
Add test harness for serialisation
rprospero
committed
Add first real json property
rprospero
committed
Export data type
rprospero
committed
Add mask and model requirements
rprospero
committed
Start exporting metadata
rprospero
committed
Start adding sample details
rprospero
committed
Export process metadata
rprospero
committed
Export Instrument and Raw metadata
rprospero
committed
Support exporting Quantities
rprospero
committed
Remove unneeded default calls
rprospero
committed
Start writing decoder
rprospero
committed
Correctly export sample temperature
rprospero
committed
Fix notes nodes type
rprospero
committed
Decode metadata from json
rprospero
committed
Use proper bytes for numpy serialisation
rprospero
committed
Fix historical unit errors
rprospero
committed
Parse MetaNode
rprospero
committed
Use .json extension for JSON files
rprospero
committed
Establish settings for ruff and pycodestyle
rprospero
committed
Fix formatting
rprospero
committed
[pre-commit.ci lite] apply automatic fixes for ruff linting errors

pre-commit-ci-lite[bot]
authored and
rprospero
committed
Adds main check to "transforms.py"

DrPaulSharp
authored and
rprospero
committed
Start descending
rprospero
committed
Convert tail call recursion to loop
rprospero
committed
Enumerate keys for access
rprospero
committed
Descend into dicts
rprospero
committed
Fix access to dict items
rprospero
committed
Fix formatting and doctstrings
rprospero
committed
Enable tag collection
rprospero
committed
Fix PR Comments
rprospero
committed
Formatting fixes
rprospero
committed
Start encoding
rprospero
committed
Test saving with XML files
rprospero
committed
More tests for sample metadata
rprospero
committed
Switch to safe asserts
rprospero
committed
Start serialising process
rprospero
committed
Start serialising process
rprospero
committed
Write instrument tests
rprospero
committed
Start testing g5 round trip
rprospero
committed
Fix *most* of the round trip issues
rprospero
committed
Everything passes if we ignore raw
rprospero
committed
Start trying to serialise raw data
rprospero
committed
Simplify test setup
rprospero
committed
[pre-commit.ci lite] apply automatic fixes for ruff linting errors

pre-commit-ci-lite[bot]
authored and
rprospero
committed
Attach metadata to every entry
rprospero
committed
Add comments to as_h5
rprospero
committed
Fix up file handling of test
rprospero
committed
[pre-commit.ci lite] apply automatic fixes for ruff linting errors

pre-commit-ci-lite[bot]
authored and
rprospero
committed
Remove debugging print
rprospero
committed
Respond to PR suggestions
rprospero
committed
Adds local pre-commit hook for ruff linting auto fixes

DrPaulSharp
authored and
rprospero
committed
Handle bytes type object in units parser
rprospero
committed
Fix underline length in metadata export
rprospero
committed
Fix import of actual sasdata
rprospero
committed
Tweak json handling
rprospero
committed
Fix most of HDF file loading
rprospero
committed
Properly save multidimensional data
rprospero
committed
Fix parsing of exception in test
rprospero
committed
Perform serialisation test on ALL example data
rprospero
committed
Export json
rprospero
committed
[pre-commit.ci lite] apply automatic fixes for ruff linting errors

pre-commit-ci-lite[bot]
authored and
rprospero
committed
Fix json export of data objects
rprospero
committed
Fixes to json export
rprospero
committed
Respond to PR suggestions
rprospero
committed
Use file name as file id
rprospero
committed
157 refactor design documentation (#158)

authored and
rprospero
committed
Redesign tests (#155)

authored and
rprospero
committed
Mark dataload test for faster turnaround
rprospero
committed
Ruff code formatting
rprospero
committed
Fix up HDF Test case
rprospero
committed
Start moving HDF tests into James test framework
rprospero
committed
Start moving XML into James test framework
rprospero
committed
Move round trip testing into main framework
rprospero
committed
Move json testing into test framework
rprospero
committed
Eliminate old testing detritus
rprospero
committed
Start on Sesans testing
rprospero
committed
[pre-commit.ci lite] apply automatic fixes for ruff linting errors

pre-commit-ci-lite[bot]
authored and
rprospero
committed
Modifies autogen code to match ruff rules

DrPaulSharp
authored and
rprospero
committed
added rpms and ran to rebuild tables

paulneves77
authored and
rprospero
committed
ran ruff fixes

paulneves77
authored and
rprospero
committed
added 3D datatype and added Qz generalizations where obvious

paulneves77
authored and
rprospero
committed
added first attempt at ND binner which can take in I(x,y,z,u,v,...) and rebin to an N dimensional regular grid

paulneves77
authored and
rprospero
committed
added rebin and sketch of inplied qz for postprocessing

paulneves77
authored and
rprospero
committed
updated rebin, added rpm to units, and working on testing readers

paulneves77
authored and
rprospero
committed
the ND xubpixel binning appears to be working, and made some updates to the temporary hdf5 reader

paulneves77
authored and
rprospero
committed
corrected errors in qz calculator, cleaned up test_hdf5_reader, improved NDrebin local testing

paulneves77
authored and
rprospero
committed
corrected errors in qz calculator, cleaned up test_hdf5_reader, improved NDrebin local testing

paulneves77
authored and
rprospero
committed
brought over NDrebin from refactor_24_3D branch

paulneves77
authored and
rprospero
committed
started cleaning up for pull request

paulneves77
authored and
rprospero
committed
updated NDrebin a bunch and also added NDrebin testing

paulneves77
authored and
rprospero
committed
fixed temp_hdf5_reader to be slightly more compliant with NXcanSAS standards (now looks directly at canSAS_class instead of the group name. This is because the group name is allowed to be anything,…

paulneves77
authored and
rprospero
committed
[pre-commit.ci lite] apply automatic fixes for ruff linting errors

pre-commit-ci-lite[bot]
authored and
rprospero
committed
fixed apertures and run from none to empty list if missing, and fixed raw data loading if present

paulneves77
authored and
rprospero
committed
added note on using NDrebin for M dimensional integration

paulneves77
authored and
rprospero
committed
[pre-commit.ci lite] apply automatic fixes for ruff linting errors

pre-commit-ci-lite[bot]
authored and
rprospero
committed
first pass at rebasing NDrebin to a class

paulneves77
authored and
rprospero
committed
cleaned up code based on Jeff Kryzwon's suggestions and added test case for deduce_qz

paulneves77
authored and
rprospero
committed
second pass at cleaning up NDrebin class

paulneves77
authored and
rprospero
committed
removed NDrebin from this branch.

paulneves77
authored and
rprospero
committed
NDrebin class ready for testing

paulneves77
authored and
rprospero
committed
implemented minor cleanups to code

paulneves77
authored and
rprospero
committed
added unit testing for NDrebin

paulneves77
authored and
rprospero
committed
fixed a few bugs and cleaned up more

paulneves77
authored and
rprospero
committed
removed temporary testing from NDrebin.py

paulneves77
authored and
rprospero
committed
added raw back to metadata

paulneves77
authored and
rprospero
committed
cleaned up NDrebin, removed old function, added documentation

paulneves77
authored and
rprospero
committed
fixed some bugs with importing sasdata/test/sasdataloader/data/simpleexamplefile.h5. Also added support for when the NX_class attribute has a canSAS_class name. Also fixed bug when no instrument, s…

paulneves77
authored and
rprospero
committed
refactor NDRebin._build_limits to pass codescene review. vectorized and removed for loops and most conditional logic

paulneves77
authored and
rprospero
committed
fixed the collimation cansas_class attribute in the nxcansas_1Dand2D_multisasentry_multisasdata.h5, nxcansas_1Dand2D_multisasdata.h5, and nxcansas_1Dand2D_multisasentry.h5 test data files

paulneves77
authored and
rprospero
committed
fixed bug in _build_limits

paulneves77
authored and
rprospero
committed
removed local path references, removed spurious units.py

paulneves77
authored and
rprospero
committed
indented code block, clarified non-vector comment, fixed typo, removed return in NDRebin __call__

paulneves77
authored and
rprospero
committed
moved duplicate code in parse_quantity to a call of parse_float, changed name of parse_float_first to parse_float

paulneves77
authored and
rprospero
committed
Basic test harness for names
rprospero
committed
indented code block, clarified non-vector comment, fixed typo, removed return in NDRebin __call__

paulneves77
authored and
rprospero
committed
fixed minor error in reference output for nxcansas_1Dand2D_multisasdata and nxcansas_1Dand2D_multisasentry where the detector distance was read wrong because of the difference between node.astype(f…

paulneves77
authored and
rprospero
committed
Base 62 encode the hash for shorter names
rprospero
committed
Merge pull request #178 from SasView/refactor_24_NDrebin

krzywon
authored and
rprospero
committed
Name info in unique id for NamedQuantity
rprospero
committed
Update date format in refactor roadmap

DrPaulSharp
authored and
rprospero
committed
Ruff formatting
rprospero
committed
Properly attach run title and number to quantity information
rprospero
committed
Make the name a part of all quantities
rprospero
committed
Ensure that xml imports also include a proper name unique id
rprospero
committed
Ensure ASCII reader generates unique_id for data quantities
rprospero
committed
Refactor our id_header
rprospero
committed
[pre-commit.ci lite] apply automatic fixes for ruff linting errors

pre-commit-ci-lite[bot]
authored and
rprospero
committed
Minor formatting fixes
rprospero
committed
Remove debugging print statements
rprospero
committed
Merge pull request #183 from SasView/full-name-for-quantity-97
rprospero
committed
Refactor operations (#184)

authored and
rprospero
committed
Update refactor roadmap

DrPaulSharp
authored and
rprospero
committed
Adds trig and exp operations (#186)

DrPaulSharp
authored and
rprospero
committed