Conversation
… aren't available for outside accessors
… not available because of other issues.
|
Tested CI build #5559 on W11/x64. Used the 2% SDS example data and fit to sphere + hayter_msa with radius polydispersity using DREAM. Example of the new report: This PR brings useful new information. Happy to approve. |
smk78
left a comment
There was a problem hiding this comment.
Functionally, does what it says. Have not reviewed the code.
|
Code looks fine to me (just need to correct a docstring), but the part concerning the smearing info does not seem to work at 100%. I did a test selecting Instrumental Smearing = Custom Pinhole Smear: dQ/Q 1% and this info does not appear in the report. |
gonzalezma
left a comment
There was a problem hiding this comment.
Please correct the docstring and check why the information about Instrumental Smearing is not captured.
| return results_table | ||
|
|
||
| def getBatchResults(self) -> str: | ||
| """Format the bumps results correlation table into html.""" |
There was a problem hiding this comment.
Correct docstring, e.g. "Format batch results into html"
Description
This overhauls the fit reports and includes a number of new features. All plots from the results panel (including DREAM plots), smearing information, and the fit Q range (in addition to the data Q range) are now shown in the report.
I've added a method to capture the batch fitting report, but too many other things need to change to make that happen here.
Fixes #585
Fixes #1878
Fixes #3188
Refs #269
How Has This Been Tested?
Tested locally from source - verified the report opens with
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)