Skip to content

Fixes unique ID generation#3879

Merged
krzywon merged 2 commits intomainfrom
slicer_ID_fix
Feb 27, 2026
Merged

Fixes unique ID generation#3879
krzywon merged 2 commits intomainfrom
slicer_ID_fix

Conversation

@jellybean2004
Copy link
Member

Description

For multiple slicers, the slicer ID on the list in the slicer parameters window did not match that on the slicer plot. This was because the ID on the plot was adding 1 to the actual slicer number.

This PR fixes that bug by correctly generating IDs for the plots in line with the slicer parameters list.

How Has This Been Tested?

Manually ran SasView to check IDs.

Review Checklist:

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@DrPaulSharp DrPaulSharp self-requested a review February 19, 2026 17:20
@krzywon krzywon merged commit 53f40ce into main Feb 27, 2026
48 checks passed
@krzywon krzywon deleted the slicer_ID_fix branch February 27, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants