Open
Conversation
It is assumed a few lines down that source is not None
close signal was incorrectly connected to closeEvent method which generated debug tracebacks ERROR sas.qtgui.Perspectives.Fitting.FittingWidget (FittingWidget.py:148) :: TypeError: DocViewWindow.closeEvent() missing 1 required positional argument: 'event'
Render the documentation system inactive rather than crashing when the docs can't be located
…g - use the appropriate lookup method
… to inspect which button was pushed instead of looking at retval
…e entire name and not just part of it to ensure fits aren't matched to datatnames
Switch links to point to github files instead
Icon file contains 1024x1024 PNG but is only a 256x256 icon, so shrink it down to that size and also optimise the PNG compression And yes, there are 4 duplicate copies of the icon in the git repository
…e versions of the same text aren't in the code.
….1.1 release notes
Documentation fixes and v6.1.3-specific changes
…-available-in-batch-fitting point to the correct logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This has all of the v6.1.3 changes that aren't already in main. Mostly version numbers, release notes, copyright years, and the zenodo DOI, but a couple of other changes.