Add slang-server configuration schema#5741
Closed
jeet-dekivadia wants to merge 3 commits into
Closed
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
2c53564 to
091f524
Compare
|
Hi Jeet, thanks for taking the time to create this PR. When I raised the relevant issue (hudson-trading/slang-server#360), it was intended for @AndrewNolte to make this PR since he's the maintainer and the one who should probably be in the code owner file. Sorry for the confusion. |
Author
|
Thanks for clarifying, and apologies for the mix-up. I am closing this so @AndrewNolte can submit the code-owner change in the intended form. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.slang/server.jsonand.slang/local/server.jsonfilesAddresses hudson-trading/slang-server#360.
Validation
git diff --checkjq empty src/api/json/catalog.json src/schemas/json/slang-server.json src/test/slang-server/server.json src/negative_test/slang-server/invalid-doc-comment-format.json