QA: mark the KLU JET assertion broken on the LTS, where Base logging is not inference-clean - #1193
Merged
Merged
Conversation
…is not inference-clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1190.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
test/qa/jet.jl:136becomesbroken = VERSION < v"1.11".@SciMLMessagein the failure branches expands toLogging.@logmsg, and on 1.10 theBase.CoreLoggingpath it enters reachesBase.typejoin, which is itself a runtime dispatch on that version. Any solve that can emit a log therefore fails@test_opton 1.10 no matter what LinearSolve does, and 1.11 carries the Base fix.report_opton this solve gives 2 reports on 1.10.11 and 0 on 1.12.6.typejoin,CoreLogging,_emit_logandSciMLLogging. None of them namegetpropertyor_extract!, which is what separates this from the KLU internals that JET: KLUFactorization solve is no longer dispatch-clean;getpropertyself-recursion makesp, i, x, z = klu._Ldestructure a SparseMatrixCSC #1148 and KLU: extract factor parts through concrete helpers, not getproperty recursion #1163 fixed. This is not a regression of that work.brokenrather than a skip, so it registers an unexpected pass and gets removed if the assertion ever starts holding on the LTS.test/qa/jet.jlon 1.12.6 is green with zero failures, and the sparse testset reads 1 pass and 2 broken as expected. Runic is clean.QA_VERSIONS = ["1"], which overrides the["lts", "1"]intest/test_groups.toml. It bitesGROUP=QAruns on the LTS locally, and would become a CI failure if that list ever widened.AI Disclosure: Used Opus 5