-
-
Notifications
You must be signed in to change notification settings - Fork 217
output extra information from linearization #3429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is to aid in debugging initialization, then #3418 addresses exactly this issue, and would apply here as well.
src/linearization.jl
Outdated
x = u, | ||
p, | ||
t, | ||
success) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't returning success
unnecessary? If !success
then we error, so at this point success
is guaranteed to be true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a ReturnCode?
The primary motivation for this is that a linearized model is representing the dynamical system where |
also change the use of the symbol
u
in docstrings and warning messages for the more explicitunknowns
to not confuse users of input-output functions, whereu
is traditionally (also in our docs) used to denote input rather than state.