ci: revert the env: blocks that invalidated Tests.yml and SublibraryCI.yml - #4873
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Conversation
…I.yml A job that calls a reusable workflow with `uses:` may not carry an `env:` map, so adding one made both workflow files invalid: GitHub created zero jobs for them and this PR ran with no Tests and no Sublibrary CI checks at all. actionlint now passes on both again. Controlling JULIA_PKG_PRECOMPILE_AUTO has to be an input on the reusable workflows; SciML/.github#125 adds one, and this can switch to `auto-precompile: false` once that lands in the v1 tag. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Draft — please ignore until reviewed by @ChrisRackauckas.
Targets
as/fix-ci(#4867), notmaster. I don't have push access to that branch, hence a PR into it.Problem
0d3a55fde("ci: disable eager precompilation in test jobs") adds anenv:map to the two jobs that call reusable workflows withuses:. GitHub's schema doesn't allow that key there, and the failure mode is not "the env is ignored" — the entire workflow file becomes invalid and no jobs are created:That's why #4867 currently has no
Testsand noSublibrary CIchecks. The runs exist but are listed by file path with zero jobs:Worth stating explicitly, since it came up as the suspected cause: this is not a path-filtering problem. Sublibrary test-only changes do select the sublibrary —
compute_affected_sublibraries.jlputs anylib/<pkg>/**change into thedirectset (only reverse-dep propagation is gated onsrc//Project.toml), and the rootgrouped-tests.ymlmatrix isn't diff-filtered at all:→ 25 cells, the full
lib/ModelingToolkitBasegroup × version expansion. And #4843, which touched onlylib/ModelingToolkitBase/test/bvproblem.jl, ran bothTestsandSublibrary CI.Change
Revert the two
env:blocks. Both files are byte-identical tomasteragain and lint clean:The rest of #4867 (the BVP group split, the tolerance updates) is untouched.
Getting the precompile setting back
It has to be an input on the reusable workflows. SciML/.github#125 adds
auto-precompiletotests.yml(job-level, so it coversjulia-buildpkgtoo) and forwards it fromgrouped-tests.ymland all foursublibrary-project-tests.ymlshards. Once that merges andv1is retagged, these two callers become:Note
v1only moves when avX.Y.Zrelease tag is pushed, so that second step has to wait for a release cut.🤖 Generated with Claude Code
https://claude.ai/code/session_0172My4BE5TgvJmuYxkBuvxU