Fix ModelingToolkitBase QA imports on Julia 1.11 - #5028
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Fix ModelingToolkitBase QA imports on Julia 1.11#5028ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://chatgpt.com/codex/tasks/01a03a17-ad6f-7131-82fc-d0fd57ea6512
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing before
On clean
upstream/masterat24e9206e21263ae41c43148434bd4c2dd1bf1977, Julia 1.11.9 failed the ModelingToolkitBase QA group:The two findings were the implicitly imported
UnPackbinding and Julia 1.11's missingpublicmetadata for the documentedBase.Iterators.filter,map, andreverseAPIs.Passing after
The same command passes with this PR:
What changed
UnPackand@unpackare now explicitly imported while retaining the existing reexport. The three documented iterator APIs are recorded in the existing qualified-access compatibility list because Julia 1.11 does not declare thempublic; Julia 1.12 does.This addresses the Julia 1.11 findings exposed by #4989 without changing the iterator implementations or runtime behavior.
Additional verification
All three commands exited successfully with no findings.
No documentation or public API changed, so the documentation build was not run. Test groups outside
ModelingToolkitBase_QAwere not run.Ignore this PR until it has been reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code
https://chatgpt.com/codex/tasks/01a03a17-ad6f-7131-82fc-d0fd57ea6512